Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Add etcd SRV discovery support #1086
Adds the configuration options to support specifying a domain name that
Not having this capability is becoming more inconvenient when running calico-node and the calico-kube-controllers via Kubernetes.
Another attempt at getting #388 updated and merged.
@caseydavenport implementing a functional test would be pretty involved:
The code and functionality is tested fairly well in the etcd test suite:
I'd be inclined to trust that the implementation is sound - but yes, my plumbing of the SRV client to the endpoint enumeration in the calico client is still untested from a functional perspective.
Yeah, I agree - I assume you have at least tested this yourself for real? My only worry is that we'll not have a way to make sure this keeps working, or resolve any issues found in it.