Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAM utilization reporting #1087

Merged
merged 3 commits into from May 29, 2019

Conversation

Projects
None yet
4 participants
@neiljerram
Copy link
Member

commented May 23, 2019

Description

Todos

Release Note

calicoctl can now [report overall IPAM usage](https://docs.projectcalico.org/master/reference/calicoctl/ipam/show)

@neiljerram neiljerram force-pushed the neiljerram:ipam-utilization branch from 72d0a64 to 1a78e7c May 29, 2019

@neiljerram neiljerram changed the title RFC - IPAM utilization reporting IPAM utilization reporting May 29, 2019

@neiljerram neiljerram requested a review from song-jiang May 29, 2019

Show resolved Hide resolved lib/ipam/ipam.go Outdated

// GetUtilization returns IP utilization info for the specified pools, or for all pools.
func (c ipamClient) GetUtilization(ctx context.Context, args GetUtilizationArgs) ([]*PoolUtilization, error) {
var pools []*PoolUtilization

This comment has been minimized.

Copy link
@song-jiang

song-jiang May 29, 2019

Member

I am a bit confused by the name pools here, which means PoolUtilization instead of ipPools. A better name is recommended.

@song-jiang
Copy link
Member

left a comment

LGTM. Just two nits.

@neiljerram neiljerram merged commit 89ae6d0 into projectcalico:master May 29, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@neiljerram neiljerram deleted the neiljerram:ipam-utilization branch May 29, 2019

neiljerram added a commit to neiljerram/libcalico-go that referenced this pull request Jun 3, 2019

Fix IPPool creation with host-local IPAM and KDD
This reverts a misconceived change made as part of
projectcalico#1087, that causes
the following when starting up a Calico Node with KDD and host-local
IPAM.

2019-05-31 18:29:45.168 [INFO][7] startup.go 256: Early log level set to info
2019-05-31 18:29:45.169 [INFO][7] startup.go 272: Using NODENAME environment for node name
2019-05-31 18:29:45.169 [INFO][7] startup.go 284: Determined node name: wt-os-ms-e2e-k8s-stable-2-kdd-canal-148-kadm-ms
2019-05-31 18:29:45.172 [INFO][7] k8s.go 219: Using host-local IPAM
2019-05-31 18:29:45.178 [INFO][7] startup.go 316: Checking datastore connection
2019-05-31 18:29:45.200 [INFO][7] startup.go 340: Datastore connection verified
2019-05-31 18:29:45.200 [INFO][7] startup.go 95: Datastore is ready
2019-05-31 18:29:45.207 [INFO][7] customresource.go 100: Error getting resource Key=GlobalFelixConfig(name=CalicoVersion) Name="calicoversion" Resource="GlobalFelixConfigs" error=the server could not find the requested resource (get GlobalFelixConfigs.crd.projectcalico.org calicoversion)
2019-05-31 18:29:45.229 [INFO][7] startup.go 536: CALICO_IPV4POOL_NAT_OUTGOING is true (defaulted) through environment variable
2019-05-31 18:29:45.229 [INFO][7] startup.go 796: Ensure default IPv4 pool is created. IPIP mode: Never, VXLAN mode: Never
2019-05-31 18:29:45.232 [INFO][7] k8s.go 542: Attempt to 'List' using kubernetes backend is not supported.
2019-05-31 18:29:45.232 [ERROR][7] startup.go 802: Failed to create default IPv4 IP pool: 192.168.0.0/16 error=operation List is not supported on {4}
2019-05-31 18:29:45.232 [WARNING][7] startup.go 1057: Terminating
Calico node failed to start

@neiljerram neiljerram referenced this pull request Jun 3, 2019

Merged

Fix IPPool creation with host-local IPAM and KDD #1092

0 of 3 tasks complete
@caseydavenport

This comment has been minimized.

Copy link
Member

commented Jun 3, 2019

@caseydavenport caseydavenport added this to the Calico v3.8.0 milestone Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.