Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
new selectors for NP and GNP #1133
caseydavenport left a comment
@rafaelvanoni this is looking good - did a quick look through and will do a more focused one tomorrow.
I think my main feedback is that we should add a lot more tests for this functionality to make sure we're handling all the different edge cases correctly - it's a bit of code that historically has proven to be very prone to subtle bugs.
caseydavenport left a comment •
@rafaelvanoni looks really good - one minor comment, but also I think we're still missing test cases for the namespace and serviceaccount selectors using value
I agree with you on the testing against real labels - let's do that as a follow on / stretch goal once you've completed the other work on your plate.