Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ClusterIP advertisement through BGP configuration #1134

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@caseydavenport
Copy link
Member

caseydavenport commented Sep 28, 2019

Description

We already did this for ExternalIPs which is new in v3.10 here: #1123

This PR is to make the ClusterIP advertisement symmetrical. It goes with this corresponding confd PR: projectcalico/confd#272

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Configuration of Kubernetes service Cluster IP advertisement through BGPConfiguration resource.
Copy link
Member

neiljerram left a comment

A few points.

lib/apis/v3/bgpconfig.go Show resolved Hide resolved
lib/clientv3/bgpconfig_e2e_test.go Show resolved Hide resolved
@caseydavenport caseydavenport force-pushed the caseydavenport:add-cluster-ips branch from 8a61825 to ae0398b Sep 30, 2019
@caseydavenport caseydavenport merged commit 3e9f97a into projectcalico:master Sep 30, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@caseydavenport caseydavenport deleted the caseydavenport:add-cluster-ips branch Sep 30, 2019
@lmm lmm added docs-completed and removed docs-pr-required labels Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.