Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct string trim func usage #1152

Merged
merged 1 commit into from Oct 15, 2019

Conversation

@beautytiger
Copy link
Contributor

beautytiger commented Oct 15, 2019

Description

TrimLeft is char based, and TrimPrefix is word based, that's what we want here,
please see here: https://play.golang.org/p/i2idu52w9h0

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Fix issue where IPAM block affinity was not properly calculated
Copy link
Member

caseydavenport left a comment

This is great - thanks for fixing this.

@caseydavenport caseydavenport merged commit 3d38c58 into projectcalico:master Oct 15, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@caseydavenport caseydavenport added this to the Calico v3.11.0 milestone Nov 4, 2019
caseydavenport added a commit that referenced this pull request Nov 4, 2019
…-#1152-origin-release-v3.9

Automated cherry pick of #1152: correct string trim func usage
caseydavenport added a commit that referenced this pull request Nov 4, 2019
…-#1152-origin-release-v3.10

Automated cherry pick of #1152: correct string trim func usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.