Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profile ids to networkset #1158

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@robbrockbank
Copy link
Member

robbrockbank commented Nov 4, 2019

Description

This adds profiles to network sets so that we can inherit namespace labels.

There will be corresponding change required for felix.

This is essentially a bug fix, so no docs change required.

Todos

  • Tests
  • n/a Documentation
  • Release note

Release Note

Fix that namespaced network policies were not selected by namespaceSelectors 
@robbrockbank robbrockbank force-pushed the robbrockbank:add-ns-profile branch from 69f6dcf to db7e643 Nov 4, 2019
Copy link
Member

caseydavenport left a comment

LGTM

@caseydavenport caseydavenport added this to the Calico v3.11.0 milestone Nov 4, 2019
@caseydavenport caseydavenport merged commit aa6a608 into projectcalico:master Nov 4, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@robbrockbank robbrockbank deleted the robbrockbank:add-ns-profile branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.