New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NodeSelector to IP pools #993

Merged
merged 2 commits into from Jan 4, 2019

Conversation

Projects
None yet
2 participants
@caseydavenport
Copy link
Member

caseydavenport commented Dec 18, 2018

Description

Based off of this PR by @briansan. Adds a few things on top and fixes up some tests.

Todos

  • Tests
  • Documentation
  • Release note

Release Note

None required

@caseydavenport caseydavenport force-pushed the caseydavenport:briansan-ip-pool-node-selector branch from 07983f0 to 2333995 Dec 18, 2018

// The block now has no affinity, and no IPs, so it should be deleted.
out, err = bc.List(context.Background(), opts, "")
Expect(err).NotTo(HaveOccurred())
Expect(len(out.KVPairs)).To(Equal(0))

This comment has been minimized.

@briansan

briansan Jan 3, 2019

Member

nice test 👍

@briansan
Copy link
Member

briansan left a comment

LGTM

@caseydavenport caseydavenport merged commit 546924c into projectcalico:master Jan 4, 2019

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details

@caseydavenport caseydavenport deleted the caseydavenport:briansan-ip-pool-node-selector branch Jan 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment