Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkFelixHealth remove named return #329

Merged
merged 1 commit into from Sep 18, 2019

Conversation

@xieyanker
Copy link
Contributor

xieyanker commented Sep 14, 2019

Description

bug fix

if the function of resp.Body.Close() get error not nil, it will return the error about closing failed. But in my opinion,the felix maybe normal, it should not return the error about closing failed.

Todos

Release Note

None required
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Sep 14, 2019

CLA assistant check
All committers have signed the CLA.

@xieyanker

This comment has been minimized.

Copy link
Contributor Author

xieyanker commented Sep 18, 2019

/assign @caseydavenport

@tmjd
tmjd approved these changes Sep 18, 2019
Copy link
Member

tmjd left a comment

LGTM, WDYT @caseydavenport?

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Sep 18, 2019

Yeah seems fine to me. Thanks for the PR!

@caseydavenport caseydavenport merged commit 9a6c594 into projectcalico:master Sep 18, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@lmm lmm added this to the Calico v3.10.0 milestone Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.