Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding service checks for confd, bird and bird6 on the liveness probe #369

Merged
merged 2 commits into from Nov 25, 2019

Conversation

@asincu
Copy link
Contributor

asincu commented Nov 20, 2019

Description

These checks will be enabled when using option -bird-live or -bird6-live for the liveness probe. The default will be false.

projectcalico/calico#2889

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Adding -bird-live/-bird6-live option to check for bird, bird6 and conf as part of the liveness probe. 
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Nov 20, 2019

CLA assistant check
All committers have signed the CLA.

These checks will be enabled when using option --bird-live for the liveness probe. The default will be false.
@asincu asincu force-pushed the asincu:liveness_checks branch from 2ca7220 to 60866dc Nov 20, 2019
Copy link
Member

matthewdupre left a comment

Couple of changes needed. Also wondering if there are tests for this area? (I'm not sure it's worth adding them if there aren't any, but if nearby code is covered it would be nice to extend.)

pkg/health/health.go Outdated Show resolved Hide resolved
pkg/health/health.go Outdated Show resolved Hide resolved
pkg/health/health.go Outdated Show resolved Hide resolved
@asincu asincu force-pushed the asincu:liveness_checks branch 5 times, most recently from 22aedc4 to a32603d Nov 21, 2019
- Adding -bird6-live option to check for bird6 and confd
- Allow all parameters to be used interchangeably
- Add st tests for new readiness probe
@asincu asincu force-pushed the asincu:liveness_checks branch from a32603d to 37ad037 Nov 22, 2019
Copy link
Member

caseydavenport left a comment

This LGTM @asincu

We'll need a change to the Calico repository to update the manifests to include these to the liveness probes.

We should back port this to v3.8+

@asincu asincu requested a review from matthewdupre Nov 22, 2019
Copy link
Member

matthewdupre left a comment

Thanks!

@matthewdupre matthewdupre merged commit 84f40f2 into projectcalico:master Nov 25, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@asincu asincu deleted the asincu:liveness_checks branch Nov 25, 2019
@lmm lmm modified the milestones: Calico v3.10.2, Calico v3.11.0 Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.