Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use unidirectional BGP connections in the node-to-node mesh #79
Works around a bug in the BGP graceful restart protocol:
This change makes it so the BGP connection is only opened in one direction.
Since we're now relying on the connection timer, tune the timer values
left a comment
This looks good to me. I'd just note that we won't get the benefit of this if someone has configured explicit peerings (e.g. with selectors) between the Calico nodes, and it would be nice if we could have unidirectionality in that case too (when we know that both ends of a peering are Calico nodes).