New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #88 : Needs to clear NodeNetworkUnavailable flag on Kubernetes #89

Merged
merged 1 commit into from Nov 3, 2018

Conversation

Projects
None yet
3 participants
@aarnaud
Copy link
Contributor

aarnaud commented Oct 24, 2018

Previous PR : projectcalico/libcalico-go#945

Calico has to update the NetworkUnavailable status on node

We have to add new authorization to calico-node

kind: ClusterRole
apiVersion: rbac.authorization.k8s.io/v1beta1
metadata:
  name: calico-node
rules:
  - apiGroups: [""]
    resources:
      - nodes/status
    verbs:
      - patch
      - update

Context

kubernetes/kubernetes#44254
https://kubernetes.io/docs/concepts/architecture/nodes/#condition
weaveworks/weave#3307

Release Note

For compatibility with the GCE cloud provider, Calico now clears the Kubernetes NodeNetworkUnavailable condition. 
Fix #88 : Needs to clear NodeNetworkUnavailable flag on Kubernetes
Signed-off-by: Anthony ARNAUD <aarnaud@eidosmontreal.com>
@aarnaud

This comment has been minimized.

Copy link
Contributor

aarnaud commented Oct 29, 2018

Hi @caseydavenport
Do you thinks we can have this PR in the next release ?

@caseydavenport
Copy link
Member

caseydavenport left a comment

This looks reasonable to me.

Longer term, we may want to consider doing this more dynamically based on whether or not BGP is running successfully or other readiness metrics, but this is a good step.

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Nov 2, 2018

@aarnaud before I merge, could you also raise a PR in the calico repo to add the new patch permission?

Otherwise, merging this will break our integration tests.

@aarnaud

This comment has been minimized.

Copy link
Contributor

aarnaud commented Nov 2, 2018

@caseydavenport caseydavenport merged commit 441d7c2 into projectcalico:release-v3.3 Nov 3, 2018

2 checks passed

license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@arsiesys

This comment has been minimized.

Copy link

arsiesys commented Jan 7, 2019

Hi,

It seems that this PR was merged to 3.3 but not in 3.4:
https://github.com/projectcalico/node/blob/release-v3.4/pkg/startup/startup.go

@caseydavenport

This comment has been minimized.

Copy link
Member

caseydavenport commented Jan 7, 2019

@arsiesys ugh, good spot. I didn't originally realize this was targeting an older release branch.

It looks like @aarnaud has submitted new PRs - I'll make sure they get into a release. Thanks!

@caseydavenport caseydavenport removed this from the Calico v3.4.0 milestone Jan 14, 2019

@caseydavenport caseydavenport referenced this pull request Jan 14, 2019

Merged

Add missing nodes/status patch permissions to v3.3 #2368

0 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment