Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
error handling when attaching FlexVolume mounts need work #23
I don't think this is the fix to problem people are seeing, now that I look closer
The errors they see are
In particular, the string
The other fishy thing is formatting of the message:
in all the places where we log to syslog, we've marshalled the error up into JSON before writing it to standard out, e.g.
Where do we not do that?
if we fail on
So, I think what's happening is that we're failing to connect to syslog on their system, for some reason.
When that happens, we should either ignore it, and just do our business without logging to syslog, or fail in a way consistent with the FlexVolume spec, and encode the error in the JSON format.
I think I prefer the former, since kubelet or kube-controller-manager can handle logging any errors; we don't need to log to syslog.