Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change amd64 Dockerfile to ubi #30

Merged
merged 2 commits into from Nov 12, 2019
Merged

Conversation

@lmm
Copy link
Member

lmm commented Nov 6, 2019

Description

Todos

  • Tests
  • Documentation
  • Release note

Release Note

Calico component images are now using registry.access.redhat.com/ubi8/ubi-minimal:latest for the base image
Dockerfile.amd64 Outdated Show resolved Hide resolved
@lmm lmm force-pushed the lmm:lmm-update-dockerfile branch 2 times, most recently from 5168896 to ce0ca9e Nov 8, 2019
@lmm lmm force-pushed the lmm:lmm-update-dockerfile branch from ce0ca9e to d2a5fd6 Nov 8, 2019
@lmm lmm added this to the Calico v3.10.2 milestone Nov 8, 2019
Copy link
Member

tmjd left a comment

LMKWYT about the name and summary.


ARG GIT_VERSION=unknown

LABEL name="Calico pod2daemon" \

This comment has been minimized.

Copy link
@tmjd

tmjd Nov 8, 2019

Member

I don't know, maybe "Calico FlexVolume driver installer"

vendor="Project Calico" \
version=$GIT_VERSION \
release="1" \
summary="Secure connections from Kubernetes pods to local daemons using FlexVolume + Unix Domain Socket" \

This comment has been minimized.

Copy link
@tmjd

tmjd Nov 8, 2019

Member

I'd instead maybe say FlexVolume installer to setup secure connections from Kubernetes pods to local daemons.
IDK, maybe

This comment has been minimized.

Copy link
@lmm

lmm Nov 8, 2019

Author Member

That is better, thanks! 19cd0ab

LABEL name="Calico pod2daemon" \
vendor="Project Calico" \
version=$GIT_VERSION \
release="1" \

This comment has been minimized.

Copy link
@tmjd

tmjd Nov 8, 2019

Member

Same as other PR, should we be setting this.

This comment has been minimized.

Copy link
@lmm

lmm Nov 8, 2019

Author Member

I've been looking at some of the other images in the RH registry and some have just set it to release=1 across different tags. I do not think this value affects certification. I've reached out to RH for clarification but I think what we have here should be fine.

This comment has been minimized.

Copy link
@lmm

lmm Nov 9, 2019

Author Member

I reached out to RH and they've confirmed that this label is for partner use.

@tmjd
tmjd approved these changes Nov 11, 2019
Copy link
Member

tmjd left a comment

LGTM

@lmm lmm merged commit dff24a6 into projectcalico:master Nov 12, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
semaphoreci The build passed on Semaphore.
Details
@lmm lmm deleted the lmm:lmm-update-dockerfile branch Nov 12, 2019
@lmm lmm removed this from the Calico v3.10.2 milestone Dec 7, 2019
@lmm lmm added this to the Calico v3.11.0 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.