New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): allow Answers with empty value #791
Conversation
This commit adds the possibility to save/query Answers with `null` values. It also adds a new lookup mode `ISNULL` to the `HasAnswerFilter`. If this lookup mode is used, the provided `value` (if any) is ignored. Since graphql-core doesn't support `null` literals yet, the way for setting the value of an Answer to `None` is to omit the `value` field altogether. Closes projectcaluma#790 BREAKING CHANGE: `Answers` are now allowed to have `null` values.
dd05662
to
81cbe9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
Why is this a breaking change? Aren’t we just being more permissive? |
I'm not 100% sure about that. You could've relied on the backend to prevent To be safe, I'd consider all changes on the optionality of existing fields as potentially breaking. |
We claim to be web framework agnostic. So I don't think ember-caluma should have anything to do with the decision if this is a breaking change. Of course I'm aware of the fact that noone is using caluma without ember-caluma atm ;) |
It's also (and mainly) about the type system. The value types changed from |
This adds compatibility for projectcaluma/caluma#791. Instead of removing answers with an empty value, we now save the empty value. BREAKING CHANGE: Only works with caluma v4.0.0 (projectcaluma/caluma#791)
This adds compatibility for projectcaluma/caluma#791. Instead of removing answers with an empty value, we now save the empty value. BREAKING CHANGE: Only works with caluma v4.0.0 (projectcaluma/caluma#791)
# [4.0.0](v3.0.1...v4.0.0) (2019-11-21) ### Bug Fixes * **form:** transform empty string answers to null ([d3a736c](d3a736c)) ### Features * **form:** allow empty values for answers ([7e52e23](7e52e23)) ### BREAKING CHANGES * **form:** Only works with caluma v4.0.0 (projectcaluma/caluma#791)
This commit adds the possibility to save/query Answers with
null
values.
It also adds a new lookup mode
ISNULL
to theHasAnswerFilter
. Ifthis lookup mode is used, the provided
value
(if any) is ignored.Since graphql-core doesn't support
null
literals yet, the way for settingthe value of an Answer to
None
is to omit thevalue
fieldaltogether.
Closes #790 and #800
BREAKING CHANGE:
Answers
are now allowed to havenull
values.