Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for linux sockets, as suggested by @mmorandi #125

Merged
merged 3 commits into from Jun 25, 2018

Conversation

louisgag
Copy link

@louisgag louisgag commented Jun 25, 2018

adding header file which was missing and correction for opengl

@tasora tasora merged commit 9308747 into projectchrono:develop Jun 25, 2018
@rserban
Copy link
Member

rserban commented Jul 4, 2018

Louis, I have a question about the modification you made to ChOpenGLBase.h (defining the macro GLM_ENABLE_EXPERIMENTAL).
Recently but before your PR was merged, Dario Mangoni modified the CMakeLists.txt used to build the Chrono::openGL library to define this through a compile definition (see commit f814e9a).
So now we get compilation warnings about macro redefinitions.
Did the mechanism provided by Dario not work for you? Are you not using CMake to configure and build Chrono?

@louisgag
Copy link
Author

louisgag commented Jul 4, 2018

Hi Radu,
Apparently I had not pulled the latest version of CMakeLists.txt modified by Dario.
You can ignore my commit as it indeed creates a redundancy.
Sorry about this,
-Louis
PS: yes, I am using cmake and Dario's commit works fine
PPS: concerned commit: b2105bb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants