Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release 1.8] Cherry Pick #2864 #2865

Merged
merged 1 commit into from Sep 2, 2020

Conversation

mattmoor
Copy link
Contributor

@mattmoor mattmoor commented Sep 2, 2020

git cherry-pick 413fab783d9a92b660ba968e5b35ded8756be004

…ctcontour#2864)

Replace the dynamic client Get (uncached) with a read from
the informer's lister cache.  This code path is evaluated
for every HTTP Proxy on each DAG rebuild, and the call to
the API Server on each results in a thundering herd that
triggers the built-in rate limiting in k8s.io/client-go.

With this change, the only API Server calls on DAG rebuilds
happen only when our cached copy of the HTTP Proxy shows
that we need to perform a status update.

Updates projectcontour#2857

Signed-off-by: Matt Moore <mattmoor@vmware.com>
@mattmoor
Copy link
Contributor Author

mattmoor commented Sep 2, 2020

commit 413fab783d9a92b660ba968e5b35ded8756be004 (upstream/main, main)
Author: Matt Moore <mattmoor@vmware.com>
Date:   Tue Sep 1 16:54:00 2020 -0700

    Replace uncached Get to fix knative-sandbox/net-contour#226 (#2864)
    
    Replace the dynamic client Get (uncached) with a read from
    the informer's lister cache.  This code path is evaluated
    for every HTTP Proxy on each DAG rebuild, and the call to
    the API Server on each results in a thundering herd that
    triggers the built-in rate limiting in k8s.io/client-go.
    
    With this change, the only API Server calls on DAG rebuilds
    happen only when our cached copy of the HTTP Proxy shows
    that we need to perform a status update.
    
    Updates #2857
    
    Signed-off-by: Matt Moore <mattmoor@vmware.com>

@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #2865 into release-1.8 will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.8    #2865      +/-   ##
===============================================
- Coverage        76.48%   76.45%   -0.04%     
===============================================
  Files               73       73              
  Lines             5712     5712              
===============================================
- Hits              4369     4367       -2     
- Misses            1258     1259       +1     
- Partials            85       86       +1     
Impacted Files Coverage Δ
cmd/contour/serve.go 2.52% <0.00%> (-0.01%) ⬇️
internal/k8s/statusupdater.go 20.61% <0.00%> (+0.21%) ⬆️
internal/dag/cache.go 96.86% <0.00%> (-0.79%) ⬇️

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youngnick youngnick merged commit 002965d into projectcontour:release-1.8 Sep 2, 2020
@mattmoor mattmoor deleted the cp-2864 branch September 2, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants