Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site/guides: drop Gateway API v1alpha1 guide #4262

Merged
merged 2 commits into from Jan 20, 2022

Conversation

skriss
Copy link
Member

@skriss skriss commented Jan 6, 2022

Drops the Gateway API v1alpha1 guide and replaces
it with the v1alpha2 guide.

Closes #4091.

Signed-off-by: Steve Kriss krisss@vmware.com

Drops the Gateway API v1alpha1 guide and replaces
it with the v1alpha2 guide.

Closes projectcontour#4091.

Signed-off-by: Steve Kriss <krisss@vmware.com>
@skriss skriss requested a review from a team as a code owner January 6, 2022 17:12
@skriss skriss requested review from tsaarni and stevesloka and removed request for a team January 6, 2022 17:12
@skriss skriss added the do not merge Don't merge this PR until this label is removed. label Jan 6, 2022
@skriss
Copy link
Member Author

skriss commented Jan 6, 2022

Will hold on merging until just before 1.20 release, since guides aren't versioned.

@skriss skriss added the release-note/docs A documentation change for the release notes. label Jan 6, 2022
Signed-off-by: Steve Kriss <krisss@vmware.com>
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #4262 (38179ab) into main (1ee363b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4262   +/-   ##
=======================================
  Coverage   77.72%   77.72%           
=======================================
  Files         112      112           
  Lines        9995     9995           
=======================================
  Hits         7769     7769           
  Misses       2041     2041           
  Partials      185      185           

Copy link
Member

@sunjayBhatia sunjayBhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guide looks good to me 👍🏽

Copy link
Member

@youngnick youngnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice.

@youngnick youngnick merged commit 5ea058b into projectcontour:main Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Don't merge this PR until this label is removed. release-note/docs A documentation change for the release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway API: update Gateway API guide for v1alpha2
3 participants