From aff028a87a6319d1b3eda465ad4118fe0c7808ad Mon Sep 17 00:00:00 2001 From: lubronzhan Date: Tue, 16 Jan 2024 20:54:25 -0800 Subject: [PATCH 1/2] Add flag to golangci to show line number if there is error Signed-off-by: lubronzhan --- .github/workflows/prbuild.yaml | 2 +- changelogs/unreleased/6095-lubronzhan-small.md | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 changelogs/unreleased/6095-lubronzhan-small.md diff --git a/.github/workflows/prbuild.yaml b/.github/workflows/prbuild.yaml index 171be9ed48c..ce0b03b9e63 100644 --- a/.github/workflows/prbuild.yaml +++ b/.github/workflows/prbuild.yaml @@ -32,7 +32,7 @@ jobs: version: v1.55.2 # TODO: re-enable linting tools package once https://github.com/projectcontour/contour/issues/5077 # is resolved - args: --build-tags=e2e,conformance,gcp,oidc,none + args: --build-tags=e2e,conformance,gcp,oidc,none --out-${NO_FUTURE}format=colored-line-number - uses: act10ns/slack@ed1309ab9862e57e9e583e51c7889486b9a00b0f # v2.0.0 with: status: ${{ job.status }} diff --git a/changelogs/unreleased/6095-lubronzhan-small.md b/changelogs/unreleased/6095-lubronzhan-small.md new file mode 100644 index 00000000000..5ee1d76652f --- /dev/null +++ b/changelogs/unreleased/6095-lubronzhan-small.md @@ -0,0 +1 @@ +Updates to Go 1.21.6. See the [Go release notes](https://go.dev/doc/devel/release#go1.21.minor) for more information. From 9d59072d99756c957c46e62ea3cb60d4496a4173 Mon Sep 17 00:00:00 2001 From: Lubron Zhan Date: Wed, 17 Jan 2024 10:11:57 -0800 Subject: [PATCH 2/2] Remove release note and remove variable from golangci-lint arg Signed-off-by: Lubron Zhan --- .github/workflows/prbuild.yaml | 2 +- changelogs/unreleased/6095-lubronzhan-small.md | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) delete mode 100644 changelogs/unreleased/6095-lubronzhan-small.md diff --git a/.github/workflows/prbuild.yaml b/.github/workflows/prbuild.yaml index ce0b03b9e63..ff4a051aa49 100644 --- a/.github/workflows/prbuild.yaml +++ b/.github/workflows/prbuild.yaml @@ -32,7 +32,7 @@ jobs: version: v1.55.2 # TODO: re-enable linting tools package once https://github.com/projectcontour/contour/issues/5077 # is resolved - args: --build-tags=e2e,conformance,gcp,oidc,none --out-${NO_FUTURE}format=colored-line-number + args: --build-tags=e2e,conformance,gcp,oidc,none --out-format=colored-line-number - uses: act10ns/slack@ed1309ab9862e57e9e583e51c7889486b9a00b0f # v2.0.0 with: status: ${{ job.status }} diff --git a/changelogs/unreleased/6095-lubronzhan-small.md b/changelogs/unreleased/6095-lubronzhan-small.md deleted file mode 100644 index 5ee1d76652f..00000000000 --- a/changelogs/unreleased/6095-lubronzhan-small.md +++ /dev/null @@ -1 +0,0 @@ -Updates to Go 1.21.6. See the [Go release notes](https://go.dev/doc/devel/release#go1.21.minor) for more information.