Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate default cname entry #136

Closed
ehsandeep opened this issue Dec 19, 2021 · 0 comments · Fixed by #155
Closed

deprecate default cname entry #136

ehsandeep opened this issue Dec 19, 2021 · 0 comments · Fixed by #155
Assignees
@Mzack9999
Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Milestone
1.0.0

Comments

@ehsandeep
Copy link
Member

ehsandeep commented Dec 19, 2021 •
edited
Loading

Currently, a cname entry for app.INTERACTSH-DOMAIN gets created as default for any user using a self-hosted server. This is intended to use for hosting the web client at https://app.interactsh.com and should not be enabled for all users as default.

interactsh/pkg/server/dns_server.go

Line 105 in d201e37

case strings.EqualFold(domain, "app"+h.dotDomain):

This support can be optional with the additional boolean flag app-cname and will be disabled as default.
@ehsandeep ehsandeep added Priority: High After critical issues are fixed, these should be dealt with before any further issues. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. labels Dec 19, 2021
@ehsandeep ehsandeep added this to the 1.0.0 milestone Dec 25, 2021
@Mzack9999 Mzack9999 self-assigned this Dec 29, 2021
@Mzack9999 Mzack9999 linked a pull request Dec 29, 2021 that will close this issue
Making app CNAME optional #155
Merged
@Mzack9999 Mzack9999 added the Status: Review Needed The issue has a PR attached to it which needs to be reviewed label Dec 29, 2021
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Dec 29, 2021
@ehsandeep ehsandeep changed the title Optional app. cname DNS entry deprecate default cname entry Jan 23, 2022
@GoVulnBot GoVulnBot mentioned this issue Jun 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mzack9999 Mzack9999

Labels
Priority: High After critical issues are fixed, these should be dealt with before any further issues. Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Making app CNAME optional projectdiscovery/interactsh
2 participants
@ehsandeep @Mzack9999