Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Urlscan as passive source

Closed
wants to merge 2 commits into from

Conversation

CaptainFreak
Copy link

@CaptainFreak CaptainFreak commented Oct 15, 2018

This needs a lot of work.
@Ice3man543 @codingo can you please give me a developer setup and testing guide for testing out the new features while adding them. also a simple to-do list of making this a complete PR would be good. as i have noticed, due to such modularity of this project there are multiple places where i will have to make changes to completely plug in the new source. This PR just contains a very initial work for right now.

@Ice3man543
Copy link
Member

Ice3man543 commented Oct 15, 2018

@CaptainFreak Thanks for this Pull request.

@Ice3man543
Copy link
Member

Ice3man543 commented Oct 15, 2018

@CaptainFreak
Copy link
Author

CaptainFreak commented Oct 16, 2018

Looks good ? @Ice3man543

@Ice3man543
Copy link
Member

Ice3man543 commented Oct 16, 2018

@CaptainFreak looks okay 👍

I will test it tonight once i am free.

@Ice3man543 Ice3man543 self-requested a review Oct 27, 2018
Copy link
Member

@Ice3man543 Ice3man543 left a comment

@CaptainFreak The urlscan api doesn't works that way. What we actually need to do here is make a request to get all the pre-searched urls that contain domain as uber.com

See this - #82 (comment)

Instead what you are doing is submitting a url for scanning, that is not the purpose i think. Can you change this to be that way?

@ZeroDot1
Copy link

ZeroDot1 commented Feb 28, 2019

This looks interesting, why isn't it in use yet?

@Ice3man543
Copy link
Member

Ice3man543 commented Mar 1, 2019

It isn't complete yet. The pr doesn't works. And the core is somehow messed up. Don't worry, we'll be releasing something way better soon. Sorry for the delay @ZeroDot1

@ZeroDot1
Copy link

ZeroDot1 commented Mar 1, 2019

@Ice3man543 No problem, many thanks for the information, good luck for the future work.

@ehsandeep
Copy link
Member

ehsandeep commented Dec 5, 2019

Thanks for the pull request, it is added in the latest version.

@ehsandeep ehsandeep closed this Dec 5, 2019
@forgedhallpass forgedhallpass added Type: Enhancement and removed enhancement labels Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants