langneg has a circular dependency

[cedeber]

Hello, there is a circular dependency between locale.js and subtags.js.
locale.js calls subtags.js which calls back locale.js

[zbraniecki]

Is that an issue?

[cedeber]

No, not technically. I worry more about code quality and performance. In addition, spaghetti code is not known to be fun to understand/maintain. It's simply an information before it becomes big and nobody cares about anymore.

[zbraniecki]

I don't think the fact that two modules depend on each others functions makes it a spaghetti code.

@stasm -wdyt?

[cedeber]

Nothing strong here of course. As I said, it was simply informative so that maintainers know about it.

[stasm]

Thanks for filing, @cedeber. Rollup complains about this every time I build all fluent.js packages :) I agree with your assessment — it's not a serious issue, but it would be nice to fix it to reduce the build system noise. In larger projects a circular dependency may be a symptom of a deeper issue, but in this case, @fluent/langneg is so small that I don't think this cycle hurts.

That said, it should be fairly easy to fix it by moving the getLikelySubtagsMin logic out of subtags.js. Perhaps into a static method on Locale? I'll be happy to review a PR :)