Skip to content

Conversation

@eemeli
Copy link
Member

@eemeli eemeli commented Jul 20, 2021

This PR refreshes the lockfiles to use the latest versions supported by the ranges defined in package.json files, and updates internal dependencies to the latest, where those were using previous versions.

This should satisfy all of the dependabot bump PRs as well.

@eemeli eemeli requested a review from gregtatum July 20, 2021 15:29
Copy link
Member

@gregtatum gregtatum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this my first review of your code, I like to point out that I use conventional comments for my reviews. The Mozilla intl team so far has agreed that this leads to higher quality reviews that have less ambiguity, and we've adopted as a convention for our team.

Everything looks good on my end. I mostly looked at package.json updates, as the package-lock.json files are machine created. The CI is passing, so this looks good to me.

praise: Thanks for creating nice clean commits, it made the review very simple and non-controversial.

praise: Thanks for doing some of the chore work, the package-lock.json format version was annoying me, as I think I did it wrong when I was in here last.

Feel free to land code yourself when you have an r+ (approved PR) and a clean CI. It would be good to follow the same conventions of previous mergers on naming of the merge commit. I can't tell with a quick look if fluent.js is using just merges, or squash and merge.

@eemeli eemeli merged commit f1e0c27 into projectfluent:master Jul 20, 2021
@eemeli eemeli deleted the update-deps branch July 20, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants