Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#212] Avoid crashes due to accessing destroyed objects #238

Merged
merged 1 commit into from Mar 12, 2018

Conversation

@rhertzog
Copy link
Contributor

rhertzog commented Mar 12, 2018

The crashes that I have been experiencing all have backtraces leading
back to the "refresh" event and error messages explaining that we are
trying to use objects that have been destroyed.

This is the only place where we are destroying objects explicitly
instead of relying on the garbage collector. To fix the crash, I'm
simply using the remove_all_children() method instead of the
destroy_all_children() one.

Fixes #212

The crashes that I have been experiencing all have backtraces leading
back to the "refresh" event and error messages explaining that we are
trying to use objects that have been destroyed.

This is the only place where we are destroying objects explicitly
instead of relying on the garbage collector. To fix the crash, I'm
simply using the `remove_all_children()` method instead of the
`destroy_all_children()` one.

Hopefully fixes #212
@elbenfreund elbenfreund changed the title Avoid crashes due to accessing destroyed objects [#212] Avoid crashes due to accessing destroyed objects Mar 12, 2018
@elbenfreund elbenfreund merged commit 3049d84 into projecthamster:develop Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.