Bug: Group tags makes duplicate issues in special case #134

Closed
lukashx opened this Issue Jan 23, 2014 · 1 comment

Projects

None yet

2 participants

@lukashx
lukashx commented Jan 23, 2014

Create two facts with the same start time, each having two equal tags. FactTree widget will show them as 4 separate facts. This problem is caused by method itertools.groupby(). It requires facts already sorted by key (fact.id), but facts are sorted by fact.start_time and tag.name. I would suggest sorting facts by fact.start_time and then by fact.id. We can ignore sorting by tag names, it is not helpful and it is causing this very annoying issue. I tested it and it works well.

@tstriker
Contributor
tstriker commented Feb 9, 2014

how do you create two facts with same start time?

@tstriker tstriker closed this Feb 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment