Permalink
Browse files

cr related fixes - removed home path as it's not required.

  • Loading branch information...
1 parent c84e73e commit 800b4cf09e74389d836a928c9052980851899666 Amit Apple committed Jan 24, 2013
Showing with 3 additions and 7 deletions.
  1. +3 −7 Kudu.Core/Deployment/Generator/NodeSiteBuilder.cs
@@ -1,7 +1,7 @@
using Kudu.Contracts.Settings;
using Kudu.Core.SourceControl.Git;
using System;
-using System.Globalization;
+using System.IO;
using System.Threading.Tasks;
namespace Kudu.Core.Deployment.Generator
@@ -33,12 +33,8 @@ private void SafeCleanWebConfig(DeploymentContext context)
try
{
var git = new GitExecutable(Environment.RepositoryPath, DeploymentSettings.GetCommandIdleTimeout());
- if (!String.IsNullOrEmpty(HomePath))
- {
- git.SetHomePath(HomePath);
- }
- var args = String.Format(CultureInfo.InvariantCulture, "clean -f {0}\\web.config", this.ProjectPath);
- git.Execute(args);
+ string webConfigPath = Path.Combine(ProjectPath, "web.config");
+ git.Execute("clean -f " + webConfigPath);
}
catch (Exception ex)
{

3 comments on commit 800b4cf

Owner

suwatch replied Jan 24, 2013

Nodejs projects that have dependency pointing to Git SSH will require HOMEPATH to work correctly. Such as....

"dependencies": {
, "jugglingdb": "git@github.com:juggy/jugglingdb"

I guess my question is what is the issue of having HOMEPATH env?

Member

amitapl replied Jan 25, 2013

I thought it was not required to do a simple git clean command.

Owner

davidebbo replied Jan 25, 2013

Indeed, I don't see why it would be for a clean.

Generally, I'm not crazy about having all those different places create a GitExe and then set the HomePath. Since it never hurts to have it (I think), it feels like something that should just happen by default without each calling code having to worry about it.

Please sign in to comment.