Permalink
Browse files

filterOut --> shouldFilterOut.

  • Loading branch information...
Amit Apple
Amit Apple committed Dec 11, 2012
1 parent 80c6e9f commit f53c9aad92c42a2f23591dcba3d9a5caeadd9ed5
@@ -72,7 +72,7 @@ public Task Build(DeploymentContext context)
try
{
- string log = exe.ExecuteWithProgressWriter(context.Tracer, MsBuildSiteBuilder.FilterOutMsBuildWarnings, "/c " + _command, String.Empty).Item1;
+ string log = exe.ExecuteWithProgressWriter(context.Tracer, MsBuildSiteBuilder.ShouldFilterOutMsBuildWarnings, "/c " + _command, String.Empty).Item1;
customLogger.Log(log);
@@ -50,13 +50,13 @@ protected string GetMSBuildExtraArguments()
public virtual string ExecuteMSBuild(ITracer tracer, string arguments, params object[] args)
{
- return _msbuildExe.ExecuteWithProgressWriter(tracer, FilterOutMsBuildWarnings, arguments, args).Item1;
+ return _msbuildExe.ExecuteWithProgressWriter(tracer, ShouldFilterOutMsBuildWarnings, arguments, args).Item1;
}
public abstract Task Build(DeploymentContext context);
// TODO: Remove this filter once we figure out how to run the msbuild command without getting these warnings
- internal static bool FilterOutMsBuildWarnings(string outputLine)
+ internal static bool ShouldFilterOutMsBuildWarnings(string outputLine)
{
return outputLine.Contains("MSB3644:") || outputLine.Contains("MSB3270:");
}
@@ -196,7 +196,7 @@ public void Execute(ITracer tracer, Stream input, Stream output, string argument
args);
}
- public Tuple<string, string> ExecuteWithProgressWriter(ITracer tracer, Func<string, bool> filterOut, string arguments, params object[] args)
+ public Tuple<string, string> ExecuteWithProgressWriter(ITracer tracer, Func<string, bool> shouldFilterOut, string arguments, params object[] args)
{
using (var writer = new ProgressWriter())
{
@@ -205,7 +205,7 @@ public void Execute(ITracer tracer, Stream input, Stream output, string argument
return Execute(tracer,
output =>
{
- if (filterOut(output))
+ if (shouldFilterOut(output))
{
return false;
}

0 comments on commit f53c9aa

Please sign in to comment.