GitLabHQ as deployment source #226

Closed
remcoros opened this Issue Nov 21, 2012 · 5 comments

4 participants

@remcoros

I've been looking at how to support GitLabHQ (https://github.com/gitlabhq/gitlabhq) as a deployment source.
Some observations:

  • Currently, FetchHandler depends on a form variable called 'payload'. This is not used in gitlab. It just sends plain 'application/json'.
  • gitlab sends the repository url without the '.git' postfix (like github). This is not an url you can pull from (.git should be added), probably gitlabhq should add it.
  • Kudu missing support for basic authentication. SSH can't be used I think, as we don't get an ssh repository url from gitlab.
@davidebbo
projectkudu member

Unfortunately, every provider does things a bit differently, we we have different logic for Github, Bitbucket and Codeplex. Also, look at #223 and #225 where we're looking what it would take to support http://www.codebasehq.com/, which is kind of like Github but not quite.

But so far, we haven't had to deal with non-public repos that don't support ssh, which seems to be the case for GitLabHQ (correct?). So that would be a new challenge :)

@remcoros

I saw those issues yes, so I thought I would add this to the backlog as well.

Maybe detection code can be made a bit more flexible, or the possibility to override guessing with a setting.

I think the demand for more providers and different scenario's will grow eventually anyway.

@davidebbo
projectkudu member

Agreed that the list will grow, and the likelihood of them converging to a standard format is small :)

I'm open to some refactoring to make it more flexible. Though I don't see how a setting can make that work generically, unless the setting contains a big piece of code that has the parsing logic!

@davidfowl
projectkudu member

It can't be generic, the best you can do is to factor it into separate components:

interface ISettingsProvider 
{
     bool TryGetSettings(HttpContextBase context, out Settings settings);
}
@davidebbo davidebbo was assigned Nov 26, 2012
@davidebbo
projectkudu member

Closing this one, as we did do a lot of refactoring, and I believe you got the GitLabHQ support in.

@davidebbo davidebbo closed this Jan 4, 2013
@dravva dravva was assigned Feb 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment