Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

"npm install" on a git repository fails when not instiated from a client "git push" #254

Closed
amitapl opened this Issue · 4 comments

3 participants

@amitapl
Owner

http://social.msdn.microsoft.com/Forums/en-US/azuregit/thread/4879371f-f6be-4204-8d65-e6ae9bbd1035

The issue here is that the packages.json contains a git repository:
"locomotive": "git://github.com/aejay/locomotive.git#master"

This requires npm to run a "git clone" command, and for this to work, git needs to be in the PATH environment variable.

When a client is doing a "git push", it will be, 'CommandExecutor.ExecuteCommandAsync' is making sure of that, but any other way: GitHub fetch changes or even deploying an older version manually, will not go through that code and so will fail on file not found for git.exe.

@amitapl
Owner

Looking at the code again, 'CommandExecutor.ExecuteCommandAsync' is not the reason it works during push.
I think it's the fact that the deployment is initiated down the line after git.exe is executed (git.exe --> kudu.exe).

@aejay

Thanks for opening this issue; I wasn't sure where it belonged.

As mentioned in that thread, using a tarball reference is a workaround that works in my case. But I hope for a fix for those who don't discover that workaround (or even realize what the issue is).

Curious to see the outcome.

@amitapl amitapl was assigned
@amitapl
Owner

@aejay - Does this issue continue?
I tried it and it seems to work fine now.

@bradmi

Please reactivate if this still reproduces.

@bradmi bradmi closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.