Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursively call readEntries #2502

Closed
wants to merge 1 commit into from
Closed

recursively call readEntries #2502

wants to merge 1 commit into from

Conversation

watashiSHUN
Copy link
Contributor

@watashiSHUN watashiSHUN commented Jul 11, 2017 •
edited

fix issue #2501
click here to see changes without couting whitspaces

@watashiSHUN
Copy link
Contributor Author

I think we can check to see if the array size if < 100, we can avoid a second empty check...
but looking at the documentation, I am not sure if the upper bound is always gona stay at 100:

If there are no files left, or you've already called readEntries() on this FileSystemDirectoryReader, the array is empty.

@watashiSHUN
Copy link
Contributor Author

watashiSHUN commented Jan 18, 2018 •
edited

8b9ad1d
fairly simple change, I have tested it
merged since I hit this bug myself today
when pasting private function runtime in kudu....(238 files in bin/)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmelsayed ahmelsayed Awaiting requested review from ahmelsayed

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@watashiSHUN @dnfgituser @dnfclas