GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log errors to the global error log when they occur during building.
- Don't duplicate output for msbuild and npm install.
- Added assertions to function tests.
I never noticed output was duplicated.
It wasn't, and this change doesn't introduce that (which it would if I were to blindly log all errors).
But didn't we run into cases where npm was dying without outputting anything? Or is that a separate issue not yet addressed?
Also, what's not clear from the comment is what exactly does this add to the log. Obviously, you wouldn't do it if it had no effect :)
The npm issue is addressed. The output you saw was the error stream which was correct. This change makes the "Error occured" show up in the console.
It's a little hacky (hence the HACK:) since we write live output directly to the console and the GlobalLogger is also attached to console. So I need to Log an error here so that the code in kudu.exe knows that there was an overall error (Since this exception doesn't make it's way up to the exe),
This is a hacky way of doing something like MarkDeploymentAsFailed().
Ah I see.
Basic comments about the semantic of these 3 things would be nice. It's pretty confusing when you don't know the code well.
Added basic descriptions to loggers on DeploymentContext.
Added extension method to log error.