1.14.0 slowing down Eclipse (SpringTool Suite Edition)

[lombokissues]

Migrated from Google Code (issue 682)

[lombokissues]

👤 shawn.tuatara   🕗 May 28, 2014 at 16:31 UTC

I went and updated my lombok to 1.14.0 yesterday afternoon. I noticed fairly quickly that my Eclipse slowed down considerably when making changes to files. Researching it a bit further this morning I found that in the eclipse log there is a lot of error messages for lombok starting at when I upgraded. Attached is the related log file.

[lombokissues]

👤 shawn.tuatara   🕗 May 28, 2014 at 16:31 UTC

🔗 lombok-eclipse-error-log.txt

[lombokissues]

👤 reinierz   🕗 May 30, 2014 at 00:30 UTC

Dang. Can't reproduce, but that's definitely from the new code in 1.14 that attempts to find the lombok.config related to your source directory.

Which eclipse version are you using, exactly? Is there anything particularly special about that project's set up? For example, is it a so-called 'linked' resource (example: is the directory of the project someplace else, other than as a direct subdirectory to your workspace dir?)

Eclipse has a really REALLY weirdo idea of how to make strings that refer to resources in the workspace, and clearly we missed something.

[lombokissues]

👤 shawn.tuatara   🕗 May 30, 2014 at 00:35 UTC

It is a Spring Tool Suite version of Eclipse version 3.5.1 (
http://spring.io/tools). The project in question was a normal maven
project. If you need any specific information just tell me where to find it
and I can share it.

[lombokissues]

👤 reinierz   🕗 May 30, 2014 at 01:03 UTC

Okay, I have an edge release version that won't produce quite so many errors, but it 'works' by basically not supporting lombok.config at all in your particular setup, which is of course not good. For now this edge release will log whenever this failure occurs, because we really do need to figure out when this happens and how to get an absolute path.

Give it a shot and report back? Thanks a bunch for letting us know!

https://projectlombok.org/download-edge.html

If this doesn't lead anywhere useful I'm going to try and reproduce your situation, but there are tons of variables here, so that would take a long time.

[lombokissues]

👤 shawn.tuatara   🕗 May 30, 2014 at 16:29 UTC

So far this morning no errors are showing up. I did notice some lag on initial loading of a source file. As well I am noticing some odd syntax highlighting on the lombok annotations. Attached shows the @ Slf4j annotation in an italicized black font instead of the normal slightly brown font. As well when I added a @ Getter annotation on the sender it was with a blue font instead of the normal font. If I go back to 1.12.x the fonts show up normally.

[lombokissues]

👤 shawn.tuatara   🕗 May 30, 2014 at 16:29 UTC

[lombokissues]

👤 shawn.tuatara   🕗 May 30, 2014 at 16:29 UTC

[lombokissues]

👤 shawn.tuatara   🕗 May 30, 2014 at 21:25 UTC

So after using my Eclipse for the day I have not seen any errors show up in the log. Other than the weird colouring of the lombok annotations it seems to be stable. If you want me to try another edge build that would output more information and actually error again I don't have a problem trying it.

[lombokissues]

👤 Maaartinus   🕗 May 31, 2014 at 04:50 UTC

With my old Eclipse 3.7.2, I was having quite some problems and tons of "Path must include project and resource name" messages, too. Now (using the current master), they're gone. The colors aren't really weird, it's just that some areas (sometimes nearly everything) get all gray. Clicking around usually relocates the area or makes it disappear.

[lombokissues]

👤 r.spilker   🕗 Jun 03, 2014 at 22:30 UTC

This is NOT fixed at all, we merely hid the problem. The issue is that we try to find, as a sibling file to your source file, the file 'lombok.config', and there are some fancy scenarios where this doesn't work. So far we know of at least these 3:

• In javac, with some as yet unknown scenario probably involving maven.
• In eclipse, with a 'virtual file' that is simply being tossed through the parser for some source arithmatic. For example when refactoring or save actions or scala plugin stuff.
• In eclipse/rational rose, with the 'jazz' sourcecontrol system, where files aren't officially hosted on disk at all, but instead at URL 'sourcecontrol://jazz/etc', which we don't know how to resolve.

The quick and dirty non-fix for all of these scenarios is to just not look for lombok.config at all but this is NOT A SOLUTION: The lombok config system is here to stay and we can't just randomly decide it's too hard to find it and stop there. However, that is exactly what the edge release currently does - hence, not a fix.

We're currently looking into how to detect these scenarios, and, optimally, figure out how to still find lombok.config. This is an extremely difficult task because for a lot of the above scenarios, we do not have a system to reproduce, and it takes a lot of effort to create it (example: Installing rational whatsit with jazz and all that, well, that's a lot of work, obviously). So, it'll be slow going and require a lot of feedback.

We're calling it a night for now. Progress on our research is on public branch:

https://github.com/rzwitserloot/lombok/tree/configResolutionInEclipse

In the mean time we have the rather acute problem that 1.14.0 is causing tons of show-stopping problems, so most likely we'll push a release out the door soon that'll catch these issues and instead post a warning in the eclipse log imploring the user to get back to us.

[lombokissues]

👤 r.spilker   🕗 Jun 11, 2014 at 10:00 UTC

About the sourcecontrol://jazz urls: thate are some pointers in:

• https://bugs.eclipse.org/bugs/show_bug.cgi?id=378882
• https://bugs.eclipse.org/bugs/show_bug.cgi?id=403480

[lombokissues]

👤 r.spilker   🕗 Jun 24, 2014 at 18:46 UTC

Issue #733 has been merged into this issue.