New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page/section ID validation for cache files #32

Closed
shaunix opened this Issue Jul 11, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@shaunix
Contributor

shaunix commented Jul 11, 2015

Mallard 1.0 does not allow you to easily swap out the type of the id attribute for page and section elements. Cache files need to change the type from NMTOKEN to something more permissive, like text, because sections in cache files are of the form page_id#section_id. The proposed solution for cache/1.0 is to just use new patterns cache_page_attr and cache_section_attr which are defined to look just like mal_page_attr and mal_section_attr, except the id change.

We should fix this for 1.1 so that cache/1.1 can just easily override the id attribute, and reuse mal_page_attr, mal_section_attr, and any extensions to those. If we introduce cache_page_attr and cache_section_attr, let's go ahead and keep them, though they may default to being empty. They could be useful extension points (e.g. for Sites).

If we let blocks take IDs and participate in linking, let's make sure we get this right the first time for them.

@shaunix shaunix modified the milestones: 1.1, cache/1.1 Jul 11, 2015

@shaunix shaunix added the NeedsMEP label Jul 11, 2015

shaunix added a commit that referenced this issue Oct 5, 2015

Fix cache validation against Mallard 1.0
#32

For 1.1, we should modify the core schema to allow overriding the id
attribute, so we don't have to redefine page and section like this.

@shaunix shaunix removed the NeedsMEP label May 12, 2017

@shaunix

This comment has been minimized.

Contributor

shaunix commented May 12, 2017

Removing NeedsMEP label. I don't think we need a full write-up for a simple schema change. This is now in the 1.1 schema and spec, but I'm going to leave this issue open until there's a cache/1.1 schema that takes advantage of it.

@shaunix shaunix self-assigned this May 12, 2017

@shaunix

This comment has been minimized.

Contributor

shaunix commented Mar 20, 2018

Cache Files 1.1 updated to use the new patterns.
http://projectmallard.org/cache/1.1/index.html

@shaunix shaunix closed this Mar 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment