Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH WFs to publish Java images for many platforms #6110

Merged
merged 1 commit into from Feb 17, 2023

Conversation

snazy
Copy link
Member

@snazy snazy commented Feb 15, 2023

Release and snapshot publishing produces 2 different Docker images:

  • Java multi-platform / amd64, arm64, ppc64le, s390x (all those are available for OpenJDK 17)
  • Native / amd64 only

The multiplatform Docker images are created via a new shell script using docker buildx.

This change removes all Docker related settings and dependencies from the Quarkus builds.

See notes in tools/dockerbuild/README.md

Fixes #6099

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 83.96% // Head: 77.28% // Decreases project coverage by -6.69% ⚠️

Coverage data is based on head (40b1c96) compared to base (9e729c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6110      +/-   ##
============================================
- Coverage     83.96%   77.28%   -6.69%     
- Complexity        0     3765    +3765     
============================================
  Files            31      547     +516     
  Lines          1497    16938   +15441     
  Branches        240     1635    +1395     
============================================
+ Hits           1257    13090   +11833     
- Misses          172     3234    +3062     
- Partials         68      614     +546     
Flag Coverage Δ
java 76.63% <ø> (?)
python 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nessie/tools/compatibility/internal/ServerKey.java 95.45% <0.00%> (ø)
...rojectnessie/server/store/NamespaceSerializer.java 100.00% <0.00%> (ø)
...ctnessie/client/builder/BaseGetEntriesBuilder.java 35.29% <0.00%> (ø)
...rg/projectnessie/gc/identify/NoneCutoffPolicy.java 80.00% <0.00%> (ø)
...jectnessie/versioned/store/DefaultStoreWorker.java 67.30% <0.00%> (ø)
...ool/cli/options/LiveContentSetsStorageOptions.java 89.47% <0.00%> (ø)
...ojectnessie/gc/tool/cli/NessieVersionProvider.java 100.00% <0.00%> (ø)
.../projectnessie/services/rest/RestDiffResource.java 0.00% <0.00%> (ø)
...n/java/org/apache/iceberg/view/VersionSummary.java 100.00% <0.00%> (ø)
...ssie/versioned/persist/adapter/ToBranchParams.java 100.00% <0.00%> (ø)
... and 506 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/workflows/release-publish.yml Outdated Show resolved Hide resolved
.github/workflows/snapshot-publish.yml Outdated Show resolved Hide resolved
servers/build-docker-images.sh Outdated Show resolved Hide resolved
servers/build-docker-images.sh Outdated Show resolved Hide resolved
servers/build-docker-images.sh Outdated Show resolved Hide resolved
@snazy snazy force-pushed the publish-java-docker-images branch 2 times, most recently from 2f2d11b to 76a142f Compare February 16, 2023 10:59
@snazy snazy changed the title Update GH WFs to publish Java images for amd64 + arm64/v8 Update GH WFs to publish Java images for many platforms Feb 16, 2023
@snazy snazy force-pushed the publish-java-docker-images branch 2 times, most recently from 5de59a5 to f6ecb06 Compare February 16, 2023 11:09
Copy link
Member

@dimas-b dimas-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a couple more minor comments.

site/docs/try/configuration.md Outdated Show resolved Hide resolved
tools/dockerbuild/README.md Outdated Show resolved Hide resolved
tools/dockerbuild/docker/Dockerfile-jvm Show resolved Hide resolved
EXPOSE 8080
USER 1001

CMD ["./application", "-Dquarkus.http.host=0.0.0.0"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not ENTRYPOINT?

Do we want to support custom exec's into this container?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how these images work 🤷

Release and snapshot publishing produces 2 different Docker images:
* Java multi-platform / amd64, arm64, ppc64le, s390x (all those are available for OpenJDK 17)
* Native / amd64 only

The multiplatform Docker images are created via a new shell script using `docker buildx`.

This change removes all Docker related settings and dependencies from the Quarkus builds.

See notes in `tools/dockerbuild/README.md`
@snazy snazy merged commit 473b0fd into projectnessie:main Feb 17, 2023
16 of 17 checks passed
@snazy snazy deleted the publish-java-docker-images branch February 17, 2023 08:12
snazy added a commit to snazy/nessie that referenced this pull request Feb 17, 2023
broken by projectnessie#6110

Renovate error message:
_packageRules: You have included an unsupported manager in a package rule. Your list: `docker`. Supported managers are: (..., `dockerfile`, ...)._
snazy added a commit that referenced this pull request Feb 17, 2023
broken by #6110

Renovate error message:
_packageRules: You have included an unsupported manager in a package
rule. Your list: `docker`. Supported managers are: (..., `dockerfile`,
...)._

Fixes #5488
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image - native vs "pure Java"
2 participants