New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH WFs to publish Java images for many platforms #6110
Conversation
Codecov ReportBase: 83.96% // Head: 77.28% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #6110 +/- ##
============================================
- Coverage 83.96% 77.28% -6.69%
- Complexity 0 3765 +3765
============================================
Files 31 547 +516
Lines 1497 16938 +15441
Branches 240 1635 +1395
============================================
+ Hits 1257 13090 +11833
- Misses 172 3234 +3062
- Partials 68 614 +546
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2f2d11b
to
76a142f
Compare
5de59a5
to
f6ecb06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a couple more minor comments.
EXPOSE 8080 | ||
USER 1001 | ||
|
||
CMD ["./application", "-Dquarkus.http.host=0.0.0.0"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not ENTRYPOINT
?
Do we want to support custom exec's into this container?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's how these images work 🤷
Release and snapshot publishing produces 2 different Docker images: * Java multi-platform / amd64, arm64, ppc64le, s390x (all those are available for OpenJDK 17) * Native / amd64 only The multiplatform Docker images are created via a new shell script using `docker buildx`. This change removes all Docker related settings and dependencies from the Quarkus builds. See notes in `tools/dockerbuild/README.md`
f6ecb06
to
40b1c96
Compare
broken by projectnessie#6110 Renovate error message: _packageRules: You have included an unsupported manager in a package rule. Your list: `docker`. Supported managers are: (..., `dockerfile`, ...)._
Release and snapshot publishing produces 2 different Docker images:
The multiplatform Docker images are created via a new shell script using
docker buildx
.This change removes all Docker related settings and dependencies from the Quarkus builds.
See notes in
tools/dockerbuild/README.md
Fixes #6099