Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFlow diagram support #147
Conversation
yngndrw
added some commits
Jan 24, 2018
This comment has been minimized.
This comment has been minimized.
wow this is really good and theres a lot of awesome stuff here. Im just going to need some time to go through the changes, because Im currently in the process of refactoring a massive amount of the library (in the other open PR) and will probably need to do some additional refactoring. But honestly this is just pure awesome. Thanks so much. |
This comment has been minimized.
This comment has been minimized.
Happy to help. Let me know if you need anything from me after you've gone through it. |
dylanvorster
changed the base branch from
master
to
links_refactor
Feb 11, 2018
dylanvorster
merged commit 6dc3a45
into
projectstorm:links_refactor
Feb 11, 2018
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
yngndrw
deleted the
yngndrw:flow-diagram-changes
branch
Feb 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
yngndrw commentedJan 24, 2018
•
edited
Checklist
yarn run pretty
What?
There may some optimisation that could be done within the onMouseUp event of DiagramWidget, but I'm not best-placed to do that.
Also resolves issue #143.
I should note that the unit tests didn't pass before I started:
Why?
Better user experience in situations where you need to capture the flow from output nodes to input nodes.
How?
See above. ^
Feel-Good "programming lol" image: