New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart routing #161

Merged
merged 8 commits into from Feb 18, 2018

Conversation

Projects
None yet
2 participants
@klauspaiva
Copy link
Contributor

klauspaiva commented Feb 14, 2018

Checklist

  • The code has been run through pretty yarn run pretty
  • The tests pass on CircleCI
  • You have referenced the issue(s) or other PR(s) this fixes/relates-to
  • The PR Template has been filled out (see below)
  • Had a beer because you are awesome

What?

Introduces smart routing to the library.

Why?

For some use cases an automatically generated orthogonal representation of the links results in a better visualisation.
It also improves the overall aesthetic as links find their way around other nodes.

How?

Basically a combination of PathFinding.js and Paths.js, with extra bits of magic to put everything to work together. :)

Demos?

Yes, many!
There is a new storybook entry + demos for enabling it by default to confirm it works well with all other setups already handled by the library.

screen shot 2018-02-14 at 4 09 39 pm

demo

screen shot 2018-02-14 at 4 12 23 pm

screen shot 2018-02-14 at 4 12 32 pm

demo2

demo3

screen shot 2018-02-14 at 4 14 20 pm

screen shot 2018-02-14 at 4 14 37 pm

Feel-Good "programming lol" image:

image
source: https://www.improgrammer.net/best-programming-jokes/

@dylanvorster

This comment has been minimized.

Copy link
Contributor

dylanvorster commented Feb 14, 2018

My head just exploded

@dylanvorster

This comment has been minimized.

Copy link
Contributor

dylanvorster commented Feb 18, 2018

busy merging this into the 5.0.0 branch x__x

@dylanvorster dylanvorster changed the base branch from master to links_refactor Feb 18, 2018

@dylanvorster dylanvorster merged commit f811f12 into projectstorm:links_refactor Feb 18, 2018

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment