From 83a60e887ba40e3b905751985ae1cf0ec7eafdab Mon Sep 17 00:00:00 2001 From: Bart Veneman Date: Tue, 2 Jul 2019 15:33:48 +0200 Subject: [PATCH] update postcss-values-parser to 3.0.5 --- package-lock.json | 32 ++++++++++++++++---------------- package.json | 2 +- src/analyzer/values/colors.js | 15 +++++++++++++-- 3 files changed, 30 insertions(+), 19 deletions(-) diff --git a/package-lock.json b/package-lock.json index a35ff36..8054ed8 100644 --- a/package-lock.json +++ b/package-lock.json @@ -436,7 +436,7 @@ }, "ansi-escapes": { "version": "3.1.0", - "resolved": "https://registry.npmjs.org/ansi-escapes/-/ansi-escapes-3.1.0.tgz", + "resolved": "http://registry.npmjs.org/ansi-escapes/-/ansi-escapes-3.1.0.tgz", "integrity": "sha512-UgAb8H9D41AQnu/PbWlCofQVcnV4Gs2bBJi9eZPxfU/hgglFh3SMDMENRIqdr7H6XFnXdoknctFByVsCOotTVw==", "dev": true }, @@ -3155,7 +3155,7 @@ }, "doctrine": { "version": "1.5.0", - "resolved": "https://registry.npmjs.org/doctrine/-/doctrine-1.5.0.tgz", + "resolved": "http://registry.npmjs.org/doctrine/-/doctrine-1.5.0.tgz", "integrity": "sha1-N53Ocw9hZvds76TmcHoVmwLFpvo=", "dev": true, "requires": { @@ -3174,7 +3174,7 @@ }, "load-json-file": { "version": "2.0.0", - "resolved": "https://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz", + "resolved": "http://registry.npmjs.org/load-json-file/-/load-json-file-2.0.0.tgz", "integrity": "sha1-eUfkIUmvgNaWy/eXvKq8/h/inKg=", "dev": true, "requires": { @@ -3244,7 +3244,7 @@ }, "pify": { "version": "2.3.0", - "resolved": "https://registry.npmjs.org/pify/-/pify-2.3.0.tgz", + "resolved": "http://registry.npmjs.org/pify/-/pify-2.3.0.tgz", "integrity": "sha1-7RQaasBDqEnqWISY59yosVMw6Qw=", "dev": true }, @@ -3881,7 +3881,7 @@ }, "get-stream": { "version": "3.0.0", - "resolved": "https://registry.npmjs.org/get-stream/-/get-stream-3.0.0.tgz", + "resolved": "http://registry.npmjs.org/get-stream/-/get-stream-3.0.0.tgz", "integrity": "sha1-jpQ9E1jcN1VQVOy+LtsFqhdO3hQ=", "dev": true }, @@ -3993,7 +3993,7 @@ }, "got": { "version": "6.7.1", - "resolved": "https://registry.npmjs.org/got/-/got-6.7.1.tgz", + "resolved": "http://registry.npmjs.org/got/-/got-6.7.1.tgz", "integrity": "sha1-JAzQV4WpoY5WHcG0S0HHY+8ejbA=", "dev": true, "requires": { @@ -4357,7 +4357,7 @@ }, "is-accessor-descriptor": { "version": "0.1.6", - "resolved": "https://registry.npmjs.org/is-accessor-descriptor/-/is-accessor-descriptor-0.1.6.tgz", + "resolved": "http://registry.npmjs.org/is-accessor-descriptor/-/is-accessor-descriptor-0.1.6.tgz", "integrity": "sha1-qeEss66Nh2cn7u84Q/igiXtcmNY=", "dev": true, "requires": { @@ -4416,7 +4416,7 @@ }, "is-data-descriptor": { "version": "0.1.4", - "resolved": "https://registry.npmjs.org/is-data-descriptor/-/is-data-descriptor-0.1.4.tgz", + "resolved": "http://registry.npmjs.org/is-data-descriptor/-/is-data-descriptor-0.1.4.tgz", "integrity": "sha1-C17mSDiOLIYCgueT8YVv7D8wG1Y=", "dev": true, "requires": { @@ -4542,7 +4542,7 @@ }, "is-obj": { "version": "1.0.1", - "resolved": "https://registry.npmjs.org/is-obj/-/is-obj-1.0.1.tgz", + "resolved": "http://registry.npmjs.org/is-obj/-/is-obj-1.0.1.tgz", "integrity": "sha1-PkcprB9f3gJc19g6iW2rn09n2w8=", "dev": true }, @@ -5319,7 +5319,7 @@ }, "minimist": { "version": "1.2.0", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-1.2.0.tgz", "integrity": "sha1-o1AIsg9BOD7sH7kU9M1d95omQoQ=" }, "minimist-options": { @@ -5363,7 +5363,7 @@ "dependencies": { "minimist": { "version": "0.0.8", - "resolved": "https://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", + "resolved": "http://registry.npmjs.org/minimist/-/minimist-0.0.8.tgz", "integrity": "sha1-hX/Kv8M5fSYluCKCYuhqp6ARsF0=" } } @@ -5376,7 +5376,7 @@ }, "multimatch": { "version": "2.1.0", - "resolved": "https://registry.npmjs.org/multimatch/-/multimatch-2.1.0.tgz", + "resolved": "http://registry.npmjs.org/multimatch/-/multimatch-2.1.0.tgz", "integrity": "sha1-nHkGoi+0wCkZ4vX3UWG0zb1LKis=", "dev": true, "requires": { @@ -6362,9 +6362,9 @@ } }, "postcss-values-parser": { - "version": "3.0.4", - "resolved": "https://registry.npmjs.org/postcss-values-parser/-/postcss-values-parser-3.0.4.tgz", - "integrity": "sha512-ZXLmKkv82W6EqWX33tYfpN6UDysmb3xQGXlRoGbumQ9E/zrSOpS/KLL+JBqIZuzbWIeDDovxQn18XBv6oN+dTA==", + "version": "3.0.5", + "resolved": "https://registry.npmjs.org/postcss-values-parser/-/postcss-values-parser-3.0.5.tgz", + "integrity": "sha512-0N6EUBx2Vzl0c9LQipuus90EkVh7saBQFRhgAYpHHcDCIvxRt+K/q0zwcIYtDQVNs5Y9NGqei4AuCEvAOsePfQ==", "requires": { "color-name": "^1.1.4", "is-number": "^7.0.0", @@ -6878,7 +6878,7 @@ }, "safe-regex": { "version": "1.1.0", - "resolved": "https://registry.npmjs.org/safe-regex/-/safe-regex-1.1.0.tgz", + "resolved": "http://registry.npmjs.org/safe-regex/-/safe-regex-1.1.0.tgz", "integrity": "sha1-QKNmnzsHfR6UPURinhV91IAjvy4=", "dev": true, "requires": { diff --git a/package.json b/package.json index de8556e..6ec3c14 100644 --- a/package.json +++ b/package.json @@ -68,7 +68,7 @@ "is-vendor-prefixed": "^3.3.0", "path": "^0.12.7", "postcss": "^7.0.17", - "postcss-values-parser": "^3.0.4", + "postcss-values-parser": "^3.0.5", "specificity": "^0.4.1", "split-lines": "^2.0.0", "string-natural-compare": "^2.0.3", diff --git a/src/analyzer/values/colors.js b/src/analyzer/values/colors.js index 72a1c21..76a0471 100644 --- a/src/analyzer/values/colors.js +++ b/src/analyzer/values/colors.js @@ -7,14 +7,25 @@ const uniquer = require('../../utils/uniquer') function extractColorsFromDeclaration(declaration) { const colors = [] - // Temporary try-catch until https://github.com/shellscape/postcss-values-parser/issues/76 is fixed + // Try-catch to ignore values that cannot be parsed with postcss-values-parser + // Examples: + // - Base64-encoded images + // - startColorstr=\'#5243AA\', endColorstr=\'#0079bf\', GradientType=1 + // - opacity=50 + // - 1.5deg try { parse(declaration.value, {loose: true}).walk(node => { if (node.isColor) { return colors.push(node) } }) - } catch (error) {} + } catch (error) { + console.error( + `Ignoring this value: ${error.input.source} because: *${ + error.input.reason + }*` + ) + } if (colors.length > 0) { declaration.colors = colors.map(color => color.toString().trim())