feat: use Metrics.DefaultCollectorRegistry by default, add overload #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phnx47
changed the title
Closed
tomkerkhove
approved these changes
Aug 19, 2020
tomkerkhove
reviewed
Aug 19, 2020
src/Prometheus.Client.DependencyInjection/ServiceCollectionExtensions.cs
Show resolved
Hide resolved
sanych-sun
force-pushed
the
default-collector-registry
branch
from
801b07a to
1647dd0
Compare
sanych-sun
force-pushed
the
default-collector-registry
branch
from
d7fc0d0 to
a4d7e29
Compare
sanych-sun
force-pushed
the
default-collector-registry
branch
from
a4d7e29 to
318a534
Compare
sanych-sun
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve issue: #2