Skip to content

feat: use Metrics.DefaultCollectorRegistry by default, add overload #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phnx47 merged 3 commits into from
Aug 20, 2020
Merged

feat: use Metrics.DefaultCollectorRegistry by default, add overload #3

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
13015d1
feat: use Metrics.DefaultCollectorRegistry by default, add overload (#2)
phnx47 Aug 19, 2020
c93a868
Update registration
sanych-sun Aug 20, 2020
318a534
Add xml docs
sanych-sun Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion src/Prometheus.Client.DependencyInjection/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,23 @@ namespace Prometheus.Client.DependencyInjection
{
public static class ServiceCollectionExtensions
{
/// <summary>
/// Add IMetricFactory and ICollectorRegistry into service collection
/// </summary>
/// <param name="services">Service collection</param>
public static void AddMetricFactory(this IServiceCollection services)
{
services.AddSingleton<ICollectorRegistry, CollectorRegistry>();
services.AddMetricFactory(new CollectorRegistry());
}

/// <summary>
/// Add IMetricFactory and ICollectorRegistry into service collection
/// </summary>
/// <param name="services">Service collection</param>
/// <param name="collectorRegistry">Explicit collector registry to use</param>
public static void AddMetricFactory(this IServiceCollection services, ICollectorRegistry collectorRegistry)
{
services.AddSingleton(collectorRegistry);
services.AddSingleton<IMetricFactory, MetricFactory>();
}
}
Expand Down