refactor: NodeRenderer廃止、Nodeが直接コマンドを生成する方式に移行#81
Merged
Conversation
- Node.Collect(queue, ctx) を追加し、各Nodeが直接コマンドをキューに積むように変更 - NodeRendererBase, 全GLRenderer (8ファイル), ScissorStateTracker を削除 - LegacyRenderCommand, ScissorCommands を削除 - BeginTrimCommand/EndTrimCommand に置き換え、RenderCommandQueueにTrimスタック管理を統合 - DrawPieTextureCommand + GLDrawPieTextureCommandRunner を新設 - RenderContext を導入し、ウィンドウ情報をCollectに渡す - PrometeApp から UseRenderer, _renderers, ResolveRenderer を削除 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Deploying promete with
|
| Latest commit: |
85017eb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8aba24b8.promete.pages.dev |
| Branch Preview URL: | https://obsolete-node-renderer.promete.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NodeRendererBaseとその全派生クラス（8つのGLRenderer）を廃止し、各NodeがCollect(RenderCommandQueue, RenderContext)で直接レンダリングコマンドを生成する方式に移行ScissorCommandsをBeginTrimCommand/EndTrimCommandにリネームし、トリムスタック管理をRenderCommandQueueに統合（ScissorStateTrackerを削除）LegacyRenderCommand/GLLegacyRenderCommandRunnerを廃止し、DrawPieTextureCommand+GLDrawPieTextureCommandRunnerを新設してPieSpriteを近代化PrometeAppからUseRenderer,_renderers,_rendererTypes,ResolveRendererを削除変更の動機
UseRendererによるビルトインNodeのレンダリング差し替えはプラグイン間の互換性を破壊するリスクがあった変更内容
新規作成 (6ファイル)
RenderContext.cs- フレーム毎のウィンドウ情報DrawPieTextureCommand.cs- 扇状テクスチャ描画コマンドTrimCommands.cs- BeginTrimCommand / EndTrimCommandGLDrawPieTextureCommandRunner.cs/GLBeginTrimCommandRunner.cs/GLEndTrimCommandRunner.cs削除 (14ファイル)
NodeRendererBase.cs,LegacyRenderCommand.cs,ScissorCommands.csScissorStateTracker.cs,GLLegacyRenderCommandRunner.cs,GLBeginScissorCommandRunner.cs,GLEndScissorCommandRunner.csTest plan
dotnet build Promete.slnでビルドが通ることdotnet test Promete.Test/Promete.Test.csprojで全58テストが合格することdotnet run --project Promete.Example/でサンプルが正常に動作すること🤖 Generated with Claude Code