From e3e493fcccb4bec524dc164f387c0f2486ffd060 Mon Sep 17 00:00:00 2001 From: wangqing Date: Thu, 9 May 2024 11:15:18 +0800 Subject: [PATCH] Optimization: Use dict setdefault to replace if key in dict reference: https://realpython.com/python-defaultdict/ Signed-off-by: wangqing --- deleted_libraries.py | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/deleted_libraries.py b/deleted_libraries.py index b687264..dfb6f32 100755 --- a/deleted_libraries.py +++ b/deleted_libraries.py @@ -23,18 +23,18 @@ def main(): for line in file: part = line.decode().strip().split() - if len(part) == 7: - library = part[5] - comment = part[6] - - if '/lib/' in library and '(deleted)' in comment: - if path not in processes_linking_deleted_libraries: - processes_linking_deleted_libraries[path] = {} - - if library in processes_linking_deleted_libraries[path]: - processes_linking_deleted_libraries[path][library] += 1 - else: - processes_linking_deleted_libraries[path][library] = 1 + if len(part) != 7: + continue + library = part[5] + comment = part[6] + + if '/lib/' in library and '(deleted)' in comment: + if path not in processes_linking_deleted_libraries: + processes_linking_deleted_libraries[path] = {} + + processes_linking_deleted_libraries[path].setdefault(library, 0) + processes_linking_deleted_libraries[path][library] += 1 + except EnvironmentError as e: # Ignore non-existent files, since the files may have changed since # we globbed. @@ -50,10 +50,8 @@ def main(): continue libraries_seen.add(library) - if library in num_processes_per_library: - num_processes_per_library[library] += 1 - else: - num_processes_per_library[library] = 1 + num_processes_per_library.setdefault(library, 0) + num_processes_per_library[library] += 1 registry = CollectorRegistry() g = Gauge('node_processes_linking_deleted_libraries',