Skip to content

add docker build job in goreleaser + Dockerfile #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 13, 2020
Merged

add docker build job in goreleaser + Dockerfile #159

merged 3 commits into from
Jul 13, 2020

Conversation

@Nexucis
Copy link
Contributor

@Nexucis Nexucis commented May 31, 2020 •
edited
Loading

  • Didn't get for the moment how goreleaser will login to docker.io

related to the issue #146

@Nexucis
add docker build job in goreleaser + Dockerfile
e0c28e0 
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
@Nexucis Nexucis requested a review from slrtbtfs May 31, 2020 13:10
slrtbtfs
slrtbtfs reviewed May 31, 2020
View reviewed changes
.goreleaser.yml
dockers:
-
goos: linux
goarch: amd64
Copy link
Member

@slrtbtfs slrtbtfs May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess having images for other architectures (at least arm64) doesn't hurt.

Copy link
Contributor Author

@Nexucis Nexucis May 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would mean I have to create multiple different configuration to create and push the docker image. I'm not sure it's worth it.
We could still do it later if someone is asking. But I doubt a bit on that.

@slrtbtfs
Copy link
Member

slrtbtfs commented May 31, 2020

Didn't get for the moment how goreleaser will login to docker.io.

The PR shouldn't be merged until this is figured out, right?

@Nexucis
Copy link
Contributor Author

Nexucis commented May 31, 2020

Yeah it's safer to not merge it. To avoid a build failure during a release of the repo

@Nexucis Nexucis changed the title add docker build job in goreleaser + Dockerfile [DO NOT MERGE] add docker build job in goreleaser + Dockerfile May 31, 2020
@Nexucis
Copy link
Contributor Author

Nexucis commented May 31, 2020 •
edited
Loading

So I added a command to manually login to the docker registry.
Someone who has the right will have to fill the variable in circle-ci. ( And I don't have it and I don't know the login actually ^^)

Maybe @SuperQ you can help us on that if it's ok for you :)

@slrtbtfs slrtbtfs marked this pull request as draft June 17, 2020 10:56
@Nexucis
manually login into the docker registry
35e7c0b 
Signed-off-by: Augustin Husson <augustin.husson@amadeus.com>
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the feature/dockerfile branch from 7c447b5 to 35e7c0b Compare July 13, 2020 08:55
@Nexucis
add quay.io registry
44b15c2 
Signed-off-by: Augustin Husson <husson.augustin@gmail.com>
@Nexucis Nexucis force-pushed the feature/dockerfile branch from 4a35ffa to 44b15c2 Compare July 13, 2020 12:23
@Nexucis Nexucis changed the title [DO NOT MERGE] add docker build job in goreleaser + Dockerfile add docker build job in goreleaser + Dockerfile Jul 13, 2020
@Nexucis Nexucis marked this pull request as ready for review July 13, 2020 12:23
@Nexucis Nexucis force-pushed the feature/dockerfile branch 6 times, most recently from d5de675 to 44b15c2 Compare July 13, 2020 13:40
@Nexucis
Copy link
Contributor Author

Nexucis commented Jul 13, 2020 •
edited
Loading

close #146

@Nexucis Nexucis merged commit d7897e8 into master Jul 13, 2020
@Nexucis Nexucis deleted the feature/dockerfile branch July 13, 2020 13:44
@Nexucis Nexucis mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slrtbtfs slrtbtfs slrtbtfs left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nexucis @slrtbtfs