copy/paste towards [4352] SMB Server Shares #501
Conversation
zeph
commented
Apr 10, 2020
- violent copy/paste of metrics
- long but readable names
- copy pasting in the for loop
- 1st round of copy/paste errors
- we shall have them all
- Counter & Gauge assigned correctly
- naming
- focus on the OpenFiles
- our own white/black Lists
- just a word
- we go nowhere with the wrong class mapping
- that was not a counter
violent copy/paste of metrics long but readable names copy pasting in the for loop 1st round of copy/paste errors we shall have them all Counter & Gauge assigned correctly naming focus on the OpenFiles our own white/black Lists just a word we go nowhere with the wrong class mapping that was not a counter
|
|
||
| ch <- prometheus.MustNewConstMetric( | ||
| c.TotalFileOpenCount, | ||
| prometheus.GaugeValue, |
There was a problem hiding this comment.
This would be a counter, right?
There was a problem hiding this comment.
not according to the dump http endpoint from the perflib tool
| ) | ||
|
|
||
| func init() { | ||
| registerCollector("smb_server_shares", NewSmbServerSharesCollector, "SMB Server Shares") |
There was a problem hiding this comment.
I think maybe we'd like to keep other SMB-related metrics in the same collector, so generalise this to just being the smb collector
(Unless there's something I'm missing which makes that a bad idea)
There was a problem hiding this comment.
sure, I just reflected the naming structure I saw so far
...I'll change it to smb
| nil, | ||
| ), | ||
| TotalFileOpenCount: prometheus.NewDesc( | ||
| prometheus.BuildFQName(Namespace, subsystem, "file_open_count"), |
There was a problem hiding this comment.
This should have a _total suffix
| nil, | ||
| ), | ||
| FilesOpenedPerSec: prometheus.NewDesc( | ||
| prometheus.BuildFQName(Namespace, subsystem, "files_opened_total"), |
There was a problem hiding this comment.
Isn't this the same as the above metric?
There was a problem hiding this comment.
hah, no idea... I did grab what I could out of perflib
| // :9432/dump?query=4352#4352 | ||
| type SmbServerShares struct { | ||
| Name string | ||
| /* |
There was a problem hiding this comment.
Do you intend to add the commented out metrics later, or are they documentation for what else exists?
There was a problem hiding this comment.
i wanted to implement ALL i could see from perflib, but then I was running out of time
...this code was developed over the weekend during an outage at a customer as a tool to triage
| return nil | ||
| } | ||
|
|
||
| // :9432/dump?query=4352#4352 |
There was a problem hiding this comment.
it's the URL query to perflib (I had not found the microsoft documentation reference as u had in there from the copy&paste source file I used... the logic_drivers one)... I believe it is the class id in the array/list in perflib memory
