New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Gemfile to install sqlite outside of development #386

Merged
merged 1 commit into from Apr 23, 2015

Conversation

Projects
None yet
3 participants
@crccheck
Contributor

crccheck commented Apr 20, 2015

I was trying the official docker image with a sqlite database backend to play around, and got this error:

Specified 'sqlite3' for database adapter, but the gem is not loaded. Add `gem 'sqlite3'` to your Gemfile (and ensure its version is at the minimum required by ActiveRecord). (Gem::LoadError)

So I moved the sqlite3 gem to the general pool

@grobie @juliusv

@juliusv

This comment has been minimized.

Show comment
Hide comment
@juliusv

juliusv Apr 23, 2015

Contributor

@stuartnelson3 You good with this?

Contributor

juliusv commented Apr 23, 2015

@stuartnelson3 You good with this?

Show outdated Hide outdated Gemfile
@@ -14,8 +15,6 @@ group :production do
end
group :development do

This comment has been minimized.

@juliusv

juliusv Apr 23, 2015

Contributor

Since this group is now empty, remove it?

@juliusv

juliusv Apr 23, 2015

Contributor

Since this group is now empty, remove it?

This comment has been minimized.

@stuartnelson3

stuartnelson3 Apr 23, 2015

Collaborator

👍

@stuartnelson3

stuartnelson3 Apr 23, 2015

Collaborator

👍

@stuartnelson3

This comment has been minimized.

Show comment
Hide comment
@stuartnelson3

stuartnelson3 Apr 23, 2015

Collaborator

once that empty group is removed, 👍

Collaborator

stuartnelson3 commented Apr 23, 2015

once that empty group is removed, 👍

@crccheck

This comment has been minimized.

Show comment
Hide comment
@crccheck

crccheck Apr 23, 2015

Contributor

build https://travis-ci.org/prometheus/promdash/builds/59722951 failed, going to reopen to trigger a travis-ci rebuild to see if it was just that random seed.

Contributor

crccheck commented Apr 23, 2015

build https://travis-ci.org/prometheus/promdash/builds/59722951 failed, going to reopen to trigger a travis-ci rebuild to see if it was just that random seed.

@crccheck crccheck closed this Apr 23, 2015

@crccheck crccheck reopened this Apr 23, 2015

stuartnelson3 added a commit that referenced this pull request Apr 23, 2015

Merge pull request #386 from crccheck/sqlite-in-prod
Change Gemfile to install sqlite outside of development

@stuartnelson3 stuartnelson3 merged commit 94b7c4f into prometheus-junkyard:master Apr 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@crccheck crccheck deleted the crccheck:sqlite-in-prod branch Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment