Skip to content
This repository has been archived by the owner. It is now read-only.

Downsampling, a la Thanos #313

Closed
gouthamve opened this issue Apr 4, 2018 · 9 comments
Closed

Downsampling, a la Thanos #313

gouthamve opened this issue Apr 4, 2018 · 9 comments

Comments

Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
@gouthamve
Copy link
Collaborator

@gouthamve gouthamve commented Apr 4, 2018

The downsampling in Thanos is really interesting: https://youtu.be/l8syWgJ98sk?t=1392

@fabxc Do you think it makes sense to upstream this and also make Prometheus use this?

/cc @brian-brazil

@fabxc
Copy link
Contributor

@fabxc fabxc commented Apr 4, 2018

@gouthamve
Copy link
Collaborator Author

@gouthamve gouthamve commented Apr 4, 2018

Hmm, but reduction in CPU and query time improvements? At what scale do you think the benefits start to show?

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Apr 4, 2018

I feel like it would be useful to have downsampling in the tsdb directly. But I also agree with @fabxc that it's a little soon for this integration.

@fabxc
Copy link
Contributor

@fabxc fabxc commented Apr 4, 2018

@brian-brazil
Copy link
Contributor

@brian-brazil brian-brazil commented Apr 4, 2018

I agree with @fabxc that this doesn't make sense for Prometheus and thus the TSDB.

@AlekSi
Copy link
Contributor

@AlekSi AlekSi commented May 7, 2018

Duplicate of #56.

@fabxc
Copy link
Contributor

@fabxc fabxc commented May 28, 2018

I'd propose closing this. There are different ways to approach downsampling – none of them is universally better than others. I see no way for providing a canonical solution here.

@gouthamve gouthamve closed this May 30, 2018
@gouthamve
Copy link
Collaborator Author

@gouthamve gouthamve commented May 30, 2018

Agreed.

@dmitriy-lukyanchikov
Copy link

@dmitriy-lukyanchikov dmitriy-lukyanchikov commented Oct 24, 2018

Hello guys.
@fabxc @brian-brazil does it make sence to implement optional downsampling to Prometheus? We experience some issues with Thanos, and we want to implement downsampling to Prometheus itself?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.