This repository was archived by the owner on Aug 13, 2019. It is now read-only.
Reuse string buffer in stringTuples.Swap#654
Merged
codesome merged 5 commits intoprometheus-junkyard:masterfrom Jul 10, 2019
Merged
Reuse string buffer in stringTuples.Swap#654codesome merged 5 commits intoprometheus-junkyard:masterfrom
codesome merged 5 commits intoprometheus-junkyard:masterfrom
Conversation
added 2 commits
July 3, 2019 14:58
This reduces the allocs of WriteLabelIndex significantly. Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Contributor
Author
|
Here are the benchmark results |
csmarchbanks
reviewed
Jul 8, 2019
added 2 commits
July 9, 2019 13:22
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
bwplotka
approved these changes
Jul 9, 2019
Contributor
bwplotka
left a comment
bwplotka
left a comment
There was a problem hiding this comment.
LGTM! Thanks. I guess the improvement is because we sort a lot (:
csmarchbanks
approved these changes
Jul 9, 2019
Contributor
csmarchbanks
left a comment
csmarchbanks
left a comment
There was a problem hiding this comment.
LGTM, thanks for making it lazy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a broken down piece of #627
[Don't merge until Prometheus 2.11 is out]