Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container has the same liveness and readiness probe #211

Open
psibi opened this issue May 25, 2021 · 0 comments
Open

Container has the same liveness and readiness probe #211

psibi opened this issue May 25, 2021 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@psibi
Copy link

psibi commented May 25, 2021

Describe the bug

Right now the deployment yaml (from the helm chart) has the same liveness and readiness probe:

          readinessProbe:
            httpGet:
              path: /config
              port: http
            initialDelaySeconds: 1
            periodSeconds: 3
          livenessProbe:
            httpGet:
              path: /config
              port: http
            initialDelaySeconds: 10
            periodSeconds: 20

Using a static tool like kube-score throws this error:

apps/v1/Deployment prometheus-msteams in my-namespace                       💥
    [CRITICAL] Pod Probes
        · Container has the same readiness and liveness probe
            Using the same probe for liveness and readiness is very likely
            dangerous. Generally it's better to avoid the livenessProbe than
            re-using the readinessProbe.
            More information: https://github.com/zegl/kube-score/blob/master/README_PROBES.md

Version

      containers:
        - name: prometheus-msteams
          image: "quay.io/prometheusmsteams/prometheus-msteams:v1.4.1"

To Reproduce

Use the manifest generated by latest helm chart and pass it to kube-score will result in such an error pasted above.

Expected behavior

Liveness probe and readiness probe should be different. There are some recommendations here: https://github.com/zegl/kube-score/blob/master/README_PROBES.md#livenessprobe

Additional context

No additional context, but can provide if something is required.

@psibi psibi added the bug Something isn't working label May 25, 2021
@Knappek Knappek added enhancement New feature or request good first issue Good for newcomers and removed bug Something isn't working labels May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants