Add node_exporter mixin #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking good at first glance 👍 |
lilic
reviewed
Aug 26, 2019
|
We want release after it is merged. |
|
Awesome. Looking forward to a upstream community maintained mixin 🎉 |
s-urbaniak
added a commit
to s-urbaniak/kube-prometheus
that referenced
this pull request
Aug 29, 2019
Currently, we use the node:node_memory_bytes_total:sum and node:node_memory_bytes_available:sum recording rules for the memory node query. These recording rules have been removed in prometheus-operator#191. This fixes it by using raw queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching to use node_exporter mixin instead of providing recording rules and alerts ourselves.
Some alerts related to node_exporter were left untouched as they are not (yet :) ) provided by node-mixin
/cc @brancz @lilic @metalmatze @s-urbaniak