Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Re-do #163: smtp: STARTTLS before querying auth mechanisms #266
I’ve modified the pull request to check whether STARTTLS is announced by the server.
The next time people report issues with features that I contribute, I’d be happier if you could notify me and give me a chance to fix the issues instead of effectively reverting my contributions.
I think what #193 is asking for is an option for specifying InsecureSkipVerify in the TLS config, which is orthogonal to what I’m implementing here. Of course, I do realize that the change I’m making has the side-effect of exposing broken configurations that used to work before.
By the time of your contribution the rewrite was already in process and I only carried over very few changes – and none that might have been source of issues.
I'll take a look at the details tomorrow.