Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-ICMP probe #115

Closed
SuperQ opened this issue Feb 24, 2017 · 13 comments
Closed

Multi-ICMP probe #115

SuperQ opened this issue Feb 24, 2017 · 13 comments

Comments

@SuperQ
Copy link
Member

SuperQ commented Feb 24, 2017

In order to provide a more smokeping-like experience, it would be nice to have an ICMP probe mode that sends out multiple packets and buckets the probe time in a histogram and counts lost packets.

@brian-brazil
Copy link
Contributor

I'm not sure about this, why would it be limited to just ICMP?

Multiple scrapes from Prometheus could provide this for all modules.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 24, 2017

My thinking is that ICMP is lighter-weight than most of the TCP-based probes.

@brian-brazil
Copy link
Contributor

If we support it for one, we should support it for all.

Smokeping is the best smokeping.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 24, 2017

Yea, thinking about this more, I think we're already doing better than smokeping with the right PromQL.

@SuperQ SuperQ closed this as completed Feb 24, 2017
@RichiH
Copy link
Member

RichiH commented Feb 27, 2017

Smokeping is an island of data and you end up doing checks twice, though.

Some guidance for @qybl as to what's needed would be appreciated as he can implement this on company time.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 27, 2017

I had some ideas today about a better way to do smokeping-like stats.

Running Prometheus with a high scrape interval and using recording rules is OK, but I think there are better options.

What I'm thinking is not a Blackbox exporter, where the scrapes are scheduled by Prometheus, but a network prober that has its own scheduling and exports more like a normal target.

@RichiH
Copy link
Member

RichiH commented Feb 27, 2017

Is there an inherent reason why this needs to be done in an extra system? I am not saying I am opposed, just wondering.

Can you re-open this ticket for now?

@brian-brazil
Copy link
Contributor

I'd consider this out of scope for the blackbox exporter. A blackbox probe is on or off. Smokeping is gathering metrics across multiple probes.

@RichiH
Copy link
Member

RichiH commented Feb 27, 2017 via email

@brian-brazil
Copy link
Contributor

I don't see a way to have this make sense in the blackbox exporter, and I'm not even sure it works well within Prometheus. It's a specialised use case.

@SuperQ
Copy link
Member Author

SuperQ commented Feb 27, 2017

I think this is not a good fit for the blackbox exporter. But I think something similar has some more useful potential for network probing. I'd be keen on chatting about it.

@RichiH
Copy link
Member

RichiH commented Feb 27, 2017

To create a public log: @SuperQ and me keep mulling things on Hangouts and we are coming up with ideas for a network latency exporter.

@SuperQ
Copy link
Member Author

SuperQ commented Nov 5, 2018

FYI: I have a working prototype histogram ping prober.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants