Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prober and config to own package #214

Merged
merged 1 commit into from Sep 1, 2017

Conversation

@discordianfish
Copy link
Member

@discordianfish discordianfish commented Sep 1, 2017

This closes #205

@discordianfish discordianfish requested a review from brian-brazil Sep 1, 2017

import (
"context"
"net"
"regexp"
"time"

"github.com/miekg/dns"
"github.com/prometheus/blackbox_exporter/config"

This comment has been minimized.

@brian-brazil

brian-brazil Sep 1, 2017
Contributor

This is an internal dependency, so should be separated from the other 3

main.go Outdated
log.Errorf("Error parsing config file: %s", err)
return err
Probers = map[string]prober.ProbeFn{
"http": prober.ProbeFn(prober.ProbeHTTP),

This comment has been minimized.

@brian-brazil

brian-brazil Sep 1, 2017
Contributor

Why do you wrap these in ProbeFn here?

This comment has been minimized.

@discordianfish

discordianfish Sep 1, 2017
Author Member

Oh, though I had to. Fixing.

@discordianfish discordianfish force-pushed the latency-at:extract-prober branch 2 times, most recently from ec0cdea to 5adb7cd Sep 1, 2017
@discordianfish discordianfish force-pushed the latency-at:extract-prober branch from 5adb7cd to 072763a Sep 1, 2017
@discordianfish
Copy link
Member Author

@discordianfish discordianfish commented Sep 1, 2017

@brian-brazil ok, moved the internal dependencies down.

@brian-brazil brian-brazil merged commit de0fa8b into prometheus:master Sep 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants