Move prober and config to own package#214
Merged
brian-brazil merged 1 commit intoprometheus:masterfrom Sep 1, 2017
Merged
Conversation
brian-brazil
reviewed
Sep 1, 2017
prober/dns.go
Outdated
| "time" | ||
|
|
||
| "github.com/miekg/dns" | ||
| "github.com/prometheus/blackbox_exporter/config" |
Contributor
There was a problem hiding this comment.
This is an internal dependency, so should be separated from the other 3
main.go
Outdated
| log.Errorf("Error parsing config file: %s", err) | ||
| return err | ||
| Probers = map[string]prober.ProbeFn{ | ||
| "http": prober.ProbeFn(prober.ProbeHTTP), |
Contributor
There was a problem hiding this comment.
Why do you wrap these in ProbeFn here?
Member
Author
There was a problem hiding this comment.
Oh, though I had to. Fixing.
discordianfish
force-pushed
the
extract-prober
branch
2 times, most recently
from
ec0cdea to
5adb7cd
Compare
discordianfish
force-pushed
the
extract-prober
branch
from
5adb7cd to
072763a
Compare
Member
Author
|
@brian-brazil ok, moved the internal dependencies down. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #205