Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move prober and config to own package #214

Merged
merged 1 commit into from Sep 1, 2017

Conversation

discordianfish
Copy link
Member

This closes #205

prober/dns.go Outdated

import (
"context"
"net"
"regexp"
"time"

"github.com/miekg/dns"
"github.com/prometheus/blackbox_exporter/config"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an internal dependency, so should be separated from the other 3

main.go Outdated
log.Errorf("Error parsing config file: %s", err)
return err
Probers = map[string]prober.ProbeFn{
"http": prober.ProbeFn(prober.ProbeHTTP),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you wrap these in ProbeFn here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, though I had to. Fixing.

@discordianfish discordianfish force-pushed the extract-prober branch 2 times, most recently from ec0cdea to 5adb7cd Compare September 1, 2017 14:51
@discordianfish
Copy link
Member Author

@brian-brazil ok, moved the internal dependencies down.

@brian-brazil brian-brazil merged commit de0fa8b into prometheus:master Sep 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract prober from exporter
2 participants